Allow extensions#49
Draft
Weasy666 wants to merge 4 commits intonjaremko:masterfrom
Draft
Conversation
…y elements with the current quick_xml version
Contributor
Author
|
I think i've found a better solution. Will update this in the coming weeks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
Extensionsstruct and adds it to theAuthnRequest. This allows to create requests with arbitrary extensions, like this:I am not exactly happy with using a
Vec<String>as internal data for theExtensionsstruct, which means the extensions can only be serialized. Deserialization does not work with howquick-xmlis working currently, because we don't know beforehand which name each single extension element has and we are also not able to add a field with "dynamic" objectsquick-xmldoes not know how to deserialize this. It also does not have the ability to just deserialize the elements into raw strings. There is an issue for that, see tafia/quick-xml#257, but it's not implemented right now.